Skip to content

suit: Move to the new flash driver #21704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2025
Merged

suit: Move to the new flash driver #21704

merged 1 commit into from
Apr 11, 2025

Conversation

@tomchy
Copy link
Contributor

@tomchy tomchy commented Apr 11, 2025

Use the efficient, new extenal memory driver in SUIT DFU sample.

Ref: NCSDK-32779

@tomchy tomchy requested a review from a team April 11, 2025 10:11
@tomchy tomchy requested review from a team as code owners April 11, 2025 10:11
@tomchy tomchy mentioned this pull request Apr 11, 2025
Closed
@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Apr 11, 2025
@tomchy tomchy added this to the 3.0.0 milestone Apr 11, 2025
@tomchy tomchy added bugfix Fixes a known bug backport v3.0-branch labels Apr 11, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Apr 11, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
zephyr nrfconnect/sdk-zephyr@cb2537e nrfconnect/sdk-zephyr@c9a539d (main) nrfconnect/[email protected]

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Apr 11, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 5

Inputs:

Sources:

sdk-nrf: PR head: 0d03f996d419f0f27e29e99e9ef7711e2019dcf5
zephyr: PR head: c9a539dac2900d053e57d80c6f381f1b6e46dbd6

more details

sdk-nrf:

PR head: 0d03f996d419f0f27e29e99e9ef7711e2019dcf5
merge base: dd96a6891f0380216527451c537960b4d8d1f38f
target head (main): dd96a6891f0380216527451c537960b4d8d1f38f
Diff

zephyr:

PR head: c9a539dac2900d053e57d80c6f381f1b6e46dbd6
merge base: cb2537e877c693f40d9a24e800f1a5e6da133ca7
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (7) 
samples
│  ├── suit
│  │  ├── flash_companion
│  │  │  ├── boards
│  │  │  │  │ nrf54h20dk_nrf54h20_cpuapp.overlay
│  │  │  │ prj.conf
│  │  ├── smp_transfer
│  │  │  ├── boards
│  │  │  │  │ nrf54h20dk_nrf54h20_cpuapp_extflash.overlay
west.yml
zephyr
│  ├── drivers
│  │  ├── flash
│  │  │  ├── flash_mspi_nor.c
│  │  │  ├── flash_mspi_nor.h
│  │  │  │ flash_mspi_nor_quirks.h

Outputs:

Toolchain

Version: 7cbc0036f4
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:7cbc0036f4_8bf7ca4353

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 459
    • sdk-zephyr test count: 534
  • ✅ Integration tests
    • ✅ test-sdk-audio
    • ✅ test-fw-nrfconnect-nfc
    • ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • ✅ test-fw-nrfconnect-nrf-iot_thingy91
    • ✅ test-sdk-find-my
    • ✅ test-low-level
    • ✅ test-sdk-dfu
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@github-actions
Copy link

github-actions bot commented Apr 11, 2025

You can find the documentation preview for this PR here.

@tomchy tomchy force-pushed the bugfix/suit/NCSDK-32779_Optimize_extmem_driver branch 2 times, most recently from 8ae0efd to 94f26b9 Compare April 11, 2025 14:19
@NordicBuilder NordicBuilder removed the DNM label Apr 11, 2025
@rlubos rlubos force-pushed the bugfix/suit/NCSDK-32779_Optimize_extmem_driver branch from 94f26b9 to 29d3586 Compare April 11, 2025 16:39
@tomchy @rlubos
suit: Move to the new flash driver
0d03f99 
Use the efficient, new extenal memory driver in SUIT DFU sample.

Ref: NCSDK-32779

Signed-off-by: Tomasz Chyrowicz <[email protected]>
@rlubos rlubos force-pushed the bugfix/suit/NCSDK-32779_Optimize_extmem_driver branch from 29d3586 to 0d03f99 Compare April 11, 2025 16:40
@rlubos
Copy link
Contributor

rlubos commented Apr 11, 2025

@tomchy I took the liberty and rebased the PR, there was a conflict due to another manifest PR pending, causing twister failures.

@tomchy tomchy merged commit de3390b into nrfconnect:main Apr 11, 2025
14 checks passed
@tomchy tomchy deleted the bugfix/suit/NCSDK-32779_Optimize_extmem_driver branch June 25, 2025 11:37
@anangl anangl mentioned this pull request Jul 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rlubos rlubos rlubos approved these changes

@ahasztag ahasztag ahasztag approved these changes

@robertstypa robertstypa Awaiting requested review from robertstypa

@adsz-nordic adsz-nordic Awaiting requested review from adsz-nordic

@kszromek-nordic kszromek-nordic Awaiting requested review from kszromek-nordic

Assignees

No one assigned

Labels

backport v3.0-branch bugfix Fixes a known bug changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest manifest-zephyr

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@tomchy @NordicBuilder @rlubos @ahasztag